fix: Smooth transition for Container Registry enable switch #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.27% | 395/7491 |
| 🔴 | Branches | 4.57% (-0% 🔻) |
237/5184 |
| 🔴 | Functions | 3.16% | 78/2471 |
| 🔴 | Lines | 5.19% | 380/7323 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from c285c0c
Merge activity
|
Resolve #2880 **Changes:** Updates the container registry list fetch behavior to use different Apollo fetch policies based on whether it's the initial fetch or a subsequent reload: - Initial fetch uses `store-and-network` to show cached data while fetching fresh data - Subsequent fetches use `network-only` to ensure fresh data **Rationale:** This change optimizes the user experience by showing cached data immediately on first load while still ensuring up-to-date data on manual refreshes.
agatha197
force-pushed
the
fix/2880-enable-switch-in-registry-list
branch
from
17b46f7 to
c285c0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2880
Changes:
Updates the container registry list fetch behavior to use different Apollo fetch policies based on whether it's the initial fetch or a subsequent reload:
store-and-networkto show cached data while fetching fresh datanetwork-onlyto ensure fresh dataRationale:
This change optimizes the user experience by showing cached data immediately on first load while still ensuring up-to-date data on manual refreshes.